-
-
Notifications
You must be signed in to change notification settings - Fork 398
Add sftp.read to activity log
#194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add sftp.read to activity log
#194
Conversation
|
Thank you for your submission. I've looked into this, and it appears there used to be logging for SFTP read events. It was dropped during the migration to sqlite based event buffer. If memory serves, I believe it was deliberately removed due to performance concerns. I personally do like the idea of this being available. Access though the panel is logged so makes sense to be consistent, even if it has to be gated behind a config flag. So I'll see what @matthewpi want's to do about this. |
|
I don't think so that it would hit performance so much. I mean that |
|
This must be gated behind a config option before I'd consider merging it. While someone could argue writing files produces a lot of logs as it stands, writing files is definitely something we want to know about while reads are less important. Especially over a protocol like SFTP where automated tooling may be used to sync files. |
|
Should the option be enabled or disabled by default? |
The option should be named |
Done |
Adds
sftp.readto activity log when file is read in SFTP.Resolves pterodactyl/panel#5136
Linked with PR pterodactyl/panel#5148